This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [patch rfc] s/extract_address/extract_unsigned_integer/ for solib
On May 22, 3:01pm, Andrew Cagney wrote:
This does the s/extract_address/extract_unsigned_integer/ change to the
solib files.
One bit bugs me - IRIX. It's doing an unsigned extract when MIPS is
ment to always sign extend an address. It's very tempting to instead
make that code always do signextended extracts (I don't have access to
an IRIX 4 box though).
thoughts?
It looks okay to me.
I agree that extract_mips_address() in solib-irix.c probably ought to
be using extract_signed_integer(), but I too am reluctant to change it
without testing.
Why do you need an IRIX 4 box? Wouldn't IRIX 6 work?
Do you have a good test case? On IRIX 6, shlib-call.exp fails with:
FAIL: gdb.base/shlib-call.exp: print shr1(1)
FAIL: gdb.base/shlib-call.exp: print shr1(g)
FAIL: gdb.base/shlib-call.exp: run until breakpoint set at a function
FAIL: gdb.base/shlib-call.exp: print shr1(1) 2nd time
FAIL: gdb.base/shlib-call.exp: step out of shr2
FAIL: gdb.base/shlib-call.exp: print mainshr1(1) from main
FAIL: gdb.base/shlib-call.exp: step into mainshr1
with/without the change. The other solib* tests are hp specific :-/
Andrew