This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA]: gdbarch FETCH_POINTER_ARGUMENT
- From: Andrew Cagney <ac131313 at redhat dot com>
- To: Adam Fedor <fedor at doc dot com>
- Cc: GDB Patches <gdb-patches at sources dot redhat dot com>,Daniel Jacobowitz <drow at mvista dot com>
- Date: Tue, 20 May 2003 16:07:13 -0400
- Subject: Re: [RFA]: gdbarch FETCH_POINTER_ARGUMENT
- References: <3EC84B9A.8030505@doc.com>
Adam,
I need to think about FETCH_POINTER_ARGUMENT. It needs additional
parameters - something to that lets it fetch registers or memory, and
something identifying the type of pointer.
As for convert function pointer, I think, at this stage, it would be
better to simply eliminate the only call:
@@ -1894,7 +1840,7 @@ find_implementation_from_class (CORE_ADD
#endif
if (meth_str.name == sel)
- return CONVERT_FUNCPTR (meth_str.imp);
+ return CONVERT_FUNCTION_POINTER (meth_str.imp);
}
mlistnum++;
}
replacing it with the code from the default case (do nothing), and a
comment mentioning that HP was doing a pointer dereference here. I think
it is better to leave this one to someone that can both demonstrate the
need for the tweek, and that some other existing method/code isn't
sufficient (I think I've seen this before).
Andrew