This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch rfc] Fix frame_id_eq()


I've checked this in.

*WARNING* *WARNING* *WARNING*

Andrew
--- Begin Message --- Hello,

This "trivial" patch fixes frame_id_eq() so that it compares code addresses when comparing frame IDs. I'm not seeing regressions in i386, ppc, or d10v, so ...

I'll look to commit this in a few days,

Andrew
2003-04-16  Andrew Cagney  <cagney at redhat dot com>

	* frame.c (frame_id_eq): Fail when the code_addr's do not match.

Index: frame.c
===================================================================
RCS file: /cvs/src/src/gdb/frame.c,v
retrieving revision 1.108
diff -u -r1.108 frame.c
--- frame.c	16 Apr 2003 14:39:47 -0000	1.108
+++ frame.c	16 Apr 2003 17:42:03 -0000
@@ -295,10 +295,8 @@
     /* The .stack and .code are identical, the ID's are identical.  */
     eq = 1;
   else
-    /* FIXME: cagney/2003-04-06: This should be zero.  Can't yet do
-       this because most frame ID's are not being initialized
-       correctly.  */
-    eq = 1;
+    /* No luck.  */
+    eq = 0;
   if (frame_debug)
     {
       fprintf_unfiltered (gdb_stdlog, "{ frame_id_eq (l=");

--- End Message ---

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]