Re: SIM: Add support for Intel iWMMXt processor

[Daniel Jacobowitz <drow at mvista dot com>]

On Thu, Mar 27, 2003 at 09:31:49AM -0800, cgd at broadcom dot com wrote:
> At Thu, 27 Mar 2003 17:12:56 +0000 (UTC), "Nick Clifton" wrote:
> >   I am applying the attached patch below to add support for Intel's
> >   iWMMXt processor to the ARM simulator.  (The old armulator based
> >   one, not the cgen based one).
> 
> I took a look at this patch, just to see what was inside, and noticed
> definition and uses of __IWMMXT__.  Is it "the right thing" to be
> defining and using a macro name which (i believe 8-) is in the
> implementation namespace?

These patches also contain #if 0'd code; why introduce _new_ dead code?
I believe most of the #ifdefs can be safely removed.  I notice you
change one thing marked as "used by the FPE code" without conditioning
it on iWMMXt (search for 0x91).  Is that correct?

I understand you're eager to get this stuff out, but please pay
attention to what you're committing.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer