This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: Ada-related patches, part I


2003-03-03 Paul N. Hilfinger <hilfingr at otisco dot mckusick dot com>

You don't appear to have a personal assignment for GDB on file. Assuming this is being done as an employee of Act, can you please use your act e-mail address in your ChangLogs.


* defs.h (enum language): Add language_ada.

This is ok.


However, this change shouldn't be necessary. The language code should be sufficiently modula as to not need this. Can you/act at least investigate what would be needed to finish this?

* expression.h (enum exp_opcode): Add definitions of OP_ADA_ATTRIBUTE, BINOP_IN_BOUNDS, TERNOP_IN_RANGE, UNOP_QUAL,
and UNOP_IN_RANGE.
* parse.c (length_of_subexp): Add cases for new definitions in
enum exp_opcode in expression.h.
(prefixify_subexp): Ditto.

The comments on these suggest ADA specific semantics. Can you please include ADA in all their names. Otherwize approved (but a separate commit to the above as this change is orthogonal).


(mind you, again, this shouldn't be needed. Instead these operators should be objects that language specific modules can just add).

Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]