This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[commit] Use deprecated_set_frame_saved_regs / get_frame_saved_regs.


Hello,

This cleans up some of the edge cases involving frame->saved_regs.

committed,
Andrew
2003-01-08  Andrew Cagney  <cagney@redhat.com>

	* cris-tdep.c (cris_frame_init_saved_regs): Use
	get_frame_saved_regs and SIZEOF_FRAME_SAVED_REGS when copying a
	saved_regs buffer.
	* sh-tdep.c (sh_nofp_frame_init_saved_regs): Ditto.
	(sh64_nofp_frame_init_saved_regs): Ditto.
	(sh_fp_frame_init_saved_regs): Ditto.
	* arm-tdep.c: Use deprecated_set_frame_saved_regs_hack.
	* mips-tdep.c (mips_init_extra_frame_info): Ditto.
	* mcore-tdep.c (analyze_dummy_frame): Ditto.
	* mn10300-tdep.c (analyze_dummy_frame): Ditto.

Index: arm-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/arm-tdep.c,v
retrieving revision 1.96
diff -u -r1.96 arm-tdep.c
--- arm-tdep.c	8 Jan 2003 17:21:27 -0000	1.96
+++ arm-tdep.c	8 Jan 2003 19:35:52 -0000
@@ -3029,10 +3029,12 @@
   /* We can't use NUM_REGS nor NUM_PSEUDO_REGS here, since that still
      references the old architecture vector, not the one we are
      building here.  */
-  prologue_cache->saved_regs = (CORE_ADDR *)
-    xcalloc (1, (sizeof (CORE_ADDR)
-		 * (gdbarch_num_regs (gdbarch)
-		    + gdbarch_num_pseudo_regs (gdbarch))));
+  {
+    CORE_ADDR *saved_regs = xcalloc (1, (sizeof (CORE_ADDR)
+					 * (gdbarch_num_regs (gdbarch)
+					    + gdbarch_num_pseudo_regs (gdbarch))));
+    deprecated_set_frame_saved_regs_hack (prologue_cache, saved_regs);
+  }
 
   return gdbarch;
 }
Index: cris-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/cris-tdep.c,v
retrieving revision 1.42
diff -u -r1.42 cris-tdep.c
--- cris-tdep.c	8 Jan 2003 17:21:27 -0000	1.42
+++ cris-tdep.c	8 Jan 2003 19:35:54 -0000
@@ -1174,7 +1174,7 @@
       /* I don't see this ever happening, considering the context in which
          cris_frame_init_saved_regs is called (always when we're not in
          a dummy frame).  */
-      memcpy (&fi->saved_regs, dummy_regs, sizeof (fi->saved_regs));
+      memcpy (get_frame_saved_regs (fi), dummy_regs, SIZEOF_FRAME_SAVED_REGS);
     }
   else
     {    
Index: mcore-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mcore-tdep.c,v
retrieving revision 1.37
diff -u -r1.37 mcore-tdep.c
--- mcore-tdep.c	8 Jan 2003 17:21:28 -0000	1.37
+++ mcore-tdep.c	8 Jan 2003 19:35:54 -0000
@@ -290,8 +290,10 @@
   if (dummy == NULL)
     {
       struct frame_extra_info *extra_info;
+      CORE_ADDR *saved_regs;
       dummy = deprecated_frame_xmalloc ();
-      dummy->saved_regs = (CORE_ADDR *) xmalloc (SIZEOF_FRAME_SAVED_REGS);
+      saved_regs = (CORE_ADDR *) xmalloc (SIZEOF_FRAME_SAVED_REGS);
+      deprecated_set_frame_saved_regs_hack (dummy, saved_regs);
       extra_info = XMALLOC (struct frame_extra_info);
       deprecated_set_frame_extra_info_hack (dummy, extra_info);
     }
Index: mips-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mips-tdep.c,v
retrieving revision 1.158
diff -u -r1.158 mips-tdep.c
--- mips-tdep.c	8 Jan 2003 17:21:29 -0000	1.158
+++ mips-tdep.c	8 Jan 2003 19:35:57 -0000
@@ -2476,7 +2476,7 @@
 
   frame_extra_info_zalloc (fci, sizeof (struct frame_extra_info));
 
-  fci->saved_regs = NULL;
+  deprecated_set_frame_saved_regs_hack (fci, NULL);
   get_frame_extra_info (fci)->proc_desc =
     proc_desc == &temp_proc_desc ? 0 : proc_desc;
   if (proc_desc)
Index: mn10300-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mn10300-tdep.c,v
retrieving revision 1.51
diff -u -r1.51 mn10300-tdep.c
--- mn10300-tdep.c	8 Jan 2003 17:21:29 -0000	1.51
+++ mn10300-tdep.c	8 Jan 2003 19:35:57 -0000
@@ -154,6 +154,7 @@
   if (dummy == NULL)
     {
       struct frame_extra_info *extra_info;
+      CORE_ADDR *saved_regs;
       dummy = deprecated_frame_xmalloc ();
       dummy->saved_regs = xmalloc (SIZEOF_FRAME_SAVED_REGS);
       extra_info = XMALLOC (struct frame_extra_info);
Index: sh-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/sh-tdep.c,v
retrieving revision 1.92
diff -u -r1.92 sh-tdep.c
--- sh-tdep.c	8 Jan 2003 17:21:30 -0000	1.92
+++ sh-tdep.c	8 Jan 2003 19:35:59 -0000
@@ -1078,7 +1078,7 @@
       /* DANGER!  This is ONLY going to work if the char buffer format of
          the saved registers is byte-for-byte identical to the 
          CORE_ADDR regs[NUM_REGS] format used by struct frame_saved_regs! */
-      memcpy (fi->saved_regs, dummy_regs, sizeof (fi->saved_regs));
+      memcpy (get_frame_saved_regs (fi), dummy_regs, SIZEOF_FRAME_SAVED_REGS);
       return;
     }
 
@@ -1418,7 +1418,7 @@
       /* DANGER!  This is ONLY going to work if the char buffer format of
          the saved registers is byte-for-byte identical to the 
          CORE_ADDR regs[NUM_REGS] format used by struct frame_saved_regs! */
-      memcpy (fi->saved_regs, dummy_regs, sizeof (fi->saved_regs));
+      memcpy (get_frame_saved_regs (fi), dummy_regs, SIZEOF_FRAME_SAVED_REGS);
       return;
     }
 
@@ -1619,7 +1619,7 @@
       /* DANGER!  This is ONLY going to work if the char buffer format of
          the saved registers is byte-for-byte identical to the 
          CORE_ADDR regs[NUM_REGS] format used by struct frame_saved_regs! */
-      memcpy (fi->saved_regs, dummy_regs, sizeof (fi->saved_regs));
+      memcpy (get_frame_saved_regs (fi), dummy_regs, SIZEOF_FRAME_SAVED_REGS);
       return;
     }
 

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]