This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFC/gdbarch: Make OS ABI a real member of the gdbarch
On Mon, Jan 06, 2003 at 03:27:52PM -0500, Andrew Cagney wrote:
> >I belive that both of these `= ...' can be dropped - since info.osabi is
> >>explicitly initialized, no magic values are needed. This is also more
> >>consistent with it being a named enum.
> >
> >
> >Probably, but it's a little tricky; it's used to index an array, check
> >various bounds, etc. I'm going to leave that be for now.
>
> Ok, don't forget to clean this up though.
Well, I'd rather not. When this code was added, someone more familiar
with it than I am added the /* keep this zero */ comment. There's a
couple of subtleties in changing the value, and no benefit.
If it really bugs you let me know and I'll look closer.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer