This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] Cleanup configure.in (8/n)
- From: kettenis at chello dot nl
- To: gdb-patches at sources dot redhat dot com
- Cc: klee at apple dot com
- Date: Fri, 3 Jan 2003 15:22:31 +0100 (CET)
- Subject: Re: [PATCH] Cleanup configure.in (8/n)
On my build, this causes GDB to end up picking up the headers from
tcl/generic/regex.h, which error out because it hasn't included
"regguts.h":
In file included from
/home/kdienes/source/cygnus.cygnus/src/gdb/gdb_regex.h:29,
from
/home/kdienes/source/cygnus.cygnus/src/gdb/cli/cli-decode.h:22,
from
/home/kdienes/source/cygnus.cygnus/src/gdb/gdbtk/generic/gdbtk-
hooks.c:34:
/home/kdienes/source/cygnus.cygnus/src/tcl/generic/regex.h:145: parse
error before `re_void'
/home/kdienes/source/cygnus.cygnus/src/tcl/generic/regex.h:145:
warning: type defaults to `int' in declaration of `re_void'
/home/kdienes/source/cygnus.cygnus/src/tcl/generic/regex.h:145:
warning: data definition has no type or storage class
/home/kdienes/source/cygnus.cygnus/src/tcl/generic/regex.h:314: parse
error before `_ANSI_ARGS_'
/home/kdienes/source/cygnus.cygnus/src/tcl/generic/regex.h:323: parse
error before `_ANSI_ARGS_'
/home/kdienes/source/cygnus.cygnus/src/tcl/generic/regex.h:326: parse
error before `_ANSI_ARGS_'
In file included from
/home/kdienes/source/cygnus.cygnus/src/gdb/gdbtk/generic/gdbtk-
hooks.c:34:
Oops, I didn't check insight. Thanks for the report.
I checked in the attached patch, which should fix the problem.
Mark
Index: ChangeLog
from Mark Kettenis <m.kettenis@osp.nl>
* cli/cli-decode.h: Don't include "gdb_regex.h"; provide a forward
declaration for `struct re_pattern_buffer' instead.
* Makefile.in (cli_decode_h): Remove $(gdb_regex_h).
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.302
diff -u -p -r1.302 Makefile.in
--- Makefile.in 2 Jan 2003 20:29:15 -0000 1.302
+++ Makefile.in 3 Jan 2003 14:02:46 -0000
@@ -717,7 +717,7 @@ xmodem_h = xmodem.h
#
cli_cmds_h = $(srcdir)/cli/cli-cmds.h
-cli_decode_h = $(srcdir)/cli/cli-decode.h $(gdb_regex_h) $(command_h)
+cli_decode_h = $(srcdir)/cli/cli-decode.h $(command_h)
cli_dump_h = $(srcdir)/cli/cli-dump.h
cli_script_h = $(srcdir)/cli/cli-script.h
cli_setshow_h = $(srcdir)/cli/cli-setshow.h
Index: cli/cli-decode.h
===================================================================
RCS file: /cvs/src/src/gdb/cli/cli-decode.h,v
retrieving revision 1.15
diff -u -p -r1.15 cli-decode.h
--- cli/cli-decode.h 15 Jun 2002 22:05:33 -0000 1.15
+++ cli/cli-decode.h 3 Jan 2003 14:02:47 -0000
@@ -19,8 +19,9 @@
#if !defined (CLI_DECODE_H)
#define CLI_DECODE_H 1
-#include "gdb_regex.h" /* Needed by apropos_cmd. */
#include "command.h"
+
+struct re_pattern_buffer;
#if 0
/* FIXME: cagney/2002-03-17: Once cmd_type() has been removed, ``enum