This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: gdb patch to suppress empty lines, re-visited


David Carlton wrote:

I don't know if I like it or not, and I don't think I'll know until
I've actually tried it.  My first reaction is slightly negative, and
I'm not at all sure how well it will work with XEmacs's GDB mode: if I
do a bunch of steps through a function, I get output like this:

(gdb) s
(gdb)
(gdb)
(gdb)
(gdb)
(gdb)
(gdb)

because the mode isn't showing me the source code information in that
buffer (since it's available in another buffer), and I can't imagine
your patch doing anything good to that output.
But it doesn't do anything bad either.  My patch just sets a readline
flag, and my understanding is that Emacs gdb mode does not use readline.
(Exception: if you use the unmaintained tgud.el, which uses term.el's
terminal emulator.  I'd be surprised if anybody even knows about it!)

(I have no idea what
GNU Emacs's GDB mode looks like: for some reason, XEmacs uses a
different (older?) one.)  So if your patch would change the output in
this situation, I'm dubious.  But maybe it wouldn't; I'm not sure if
the ISATTY (instream) guard would protect against this situation.

It should.
--
	--Per Bothner
per@bothner.com   http://www.bothner.com/per/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]