This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [rfc] clean up linespec.c
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Wed, 6 Nov 2002 20:41:54 -0500
- Subject: Re: [rfc] clean up linespec.c
- References: <ro1u1iub2mv.fsf@jackfruit.Stanford.EDU>
On Wed, Nov 06, 2002 at 05:16:24PM -0800, David Carlton wrote:
> For various reasons, I've been cleaning up linespec.c on a branch; I
> find the resulting version of linespec.c enough more
> legible/maintainable that I suspect I'm not the only person who would
> find it useful.
>
> The cleanups consist almost entirely of refactoring rather than
> changing the behavior: I've broken up large functions into multiple
> small functions, renamed variable names to make their use clearer, and
> the like. Since I was already touching so much of the code, I also
> fixed up stylistic niceties: using NULL where appropriate, deleting
> unnecessary casts, fixing comments to end in a period followed by two
> spaces, and stuff like that.
Great. When you're done with this I may spend some time on it; I have
this pipe-dream of (changing the function's behavior slightly and)
simplifying it by adding an actual parser. I think it could be done.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer