This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] arm_store_return_value, big-endian
Err, this patch is withdrawn, and I will re-submit.
I appear to have been bitten by a bug in gnu-patch,
which placed these lines in ENTIRELY the wrong place.
Andrew, I'm sorry for snapping at you. Given the funky patch
you were looking at, your response was understandable.
Michael
Michael Snyder wrote:
>
> Michael Snyder wrote:
> >
> > Andrew Cagney wrote:
> > >
> > > > This corresponds to the earlier patch for arm_extract_return_value.
> > > >
> > > >
> > > >
> > > > 2002-11-06 Michael Snyder <msnyder@redhat.com>
> > > >
> > > > * arm-tdep.c (arm_store_return_value): Handle offset of
> > > > small types on big-endian machines.
> > > >
> > > > Index: arm-tdep.c
> > > > ===================================================================
> > > > RCS file: /cvs/src/src/gdb/arm-tdep.c,v
> > > > retrieving revision 1.74
> > > > diff -p -r1.74 arm-tdep.c
> > > > *** arm-tdep.c 1 Nov 2002 21:21:49 -0000 1.74
> > > > --- arm-tdep.c 6 Nov 2002 23:47:34 -0000
> > > > *************** gdb_print_insn_arm (bfd_vma memaddr, dis
> > > > *** 2151,2156 ****
> > > > --- 2151,2159 ----
> > > > memaddr = UNMAKE_THUMB_ADDR (memaddr);
> > > > info->symbols = &asym;
> > > > }
> > > > + else if (TYPE_LENGTH (type) < REGISTER_RAW_SIZE (A1_REGNUM))
> > > > + write_register_bytes (REGISTER_RAW_SIZE (A1_REGNUM) - TYPE_LENGTH (type),
> > > > + valbuf, TYPE_LENGTH (type));
> > > > else
> > > > info->symbols = NULL;
> > > >
> > >
> > > Write register bytes is dead.
> >
> > I'm not having this argument with you again, Andrew.
> > If you want the fix, take it. If not, don't.
>
> Hang on -- that diff is entirely wrong. My use of write_register_bytes
> was supposed to be replacing an existing use of write_register_bytes.
> Let me see what went wrong...