This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Problem about insight rename patch
- From: Pierre Muller <muller at ics dot u-strasbg dot fr>
- To: Andrew Cagney <ac131313 at redhat dot com>,Keith Seitz <keiths at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com, insight at sources dot redhat dot com
- Date: Thu, 03 Oct 2002 09:53:22 +0200
- Subject: Problem about insight rename patch
- References: <Pine.LNX.4.44.0209270750050.1515-100000@valrhona.uglyboxes.com>
At 17:16 28/09/2002 , Andrew Cagney a écrit:
>Ok, I've pulled the attached into the 5.3 branch.
>
>Sun's not yet over the yard arm so you'll have to wait a little before cracking that coldie.
This patch has a possible problem
regarding the generated init.c code:
Until now init.c contained
references to objects that are in
libgdb.a plus cli*.o or mi*.o
files.
But that patch also add
_initialize_gdbtk
function reference.
I consider this as a bug because
libgdb.a suddenly depends on gtk files
which was not the case until now.
Moreover this means that gtk is still
included in the compilation of gdb executable,
which seem to be the absolute contrary of the aim
of separating gdb and insight, no?
Basically removing
_initialize_gdbtk from init.c
does not prevent gdb from compiling,
so the only reason why I didn't send a patch proposal
is that I don't know the correct way of fixing it?
Maybe separate init.c
into init.c and insight-init.c?
But there might be better solutions?
Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller@ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07 Fax : (33)-3-88-41-40-99