This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Andrew Cagney <ac131313@ges.redhat.com> writes:Hello, This adds mmx registers to the i386.Great, a few nits though :-( * Please rename is_mmx_regnum() to mmx_regnum_p(). * Please rename nr_mmx_regs to mmx_num_regs. * Why do you use regcache_raw_read_as_address() in mmx_regnum_to_fp_regnum? Looks misleading to me...
(because I happen to know what the function does :-) I'll rename the function to ..._as_longest(). I'll fix the others. thanks, Andrew
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |