This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] more m68k multi-arch
- From: Kevin Buettner <kevinb at redhat dot com>
- To: Grace Sainsbury <graces at redhat dot com>, gdb-patches at sources dot redhat dot com
- Date: Fri, 28 Jun 2002 11:03:58 -0700
- Subject: Re: [PATCH] more m68k multi-arch
- References: <20020624131028.A1510@tomago.toronto.redhat.com>
On Jun 24, 1:10pm, Grace Sainsbury wrote:
> +#if !GDB_MULTI_ARCH
> #define STORE_STRUCT_RETURN(ADDR, SP) \
> { write_register (A1_REGNUM, (ADDR)); }
>
> @@ -221,11 +228,13 @@
> (TYPE_LENGTH(TYPE) >= 4 ? 0 : 4 - TYPE_LENGTH(TYPE)), \
> TYPE_LENGTH(TYPE))
> #endif
> +#endif //multi-arch
I've noticed the addition of a number of ``#if !GDB_MULTI_ARCH''
statements in your patch. Presumably, these are temporary until
you finish the job, right? (I'm wondering if it's necessary to
keep them around at all.)
Also... be careful with // comments. While these do work with gcc,
they don't work with all C compilers, so use /* ... */ instead.
Kevin