This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA/RFC] blockframe.c Fix errorneous addr check
- From: Kevin Buettner <kevinb at redhat dot com>
- To: Andrew Volkov <Andrew dot Volkov at transas dot com>, Kevin Buettner <kevinb at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com, jimb at redhat dot com, ezannoni at redhat dot com
- Date: Thu, 27 Jun 2002 12:18:10 -0700
- Subject: Re: [RFA/RFC] blockframe.c Fix errorneous addr check
- References: <2E74F312D6980D459F3A05492BA40F8DFE33B0@clue.transas.com>
On Jun 27, 10:58pm, Andrew Volkov wrote:
> >> current_source_end_addr = start_addr + size;
> >>
> >> but must be:
> >>
> >> current_source_end_addr = start_addr + size + <addr sizeof>;
> >>
> >> As I understand, since machine address size is not known at
> >time of parsing
> >> coff file, then we have big trouble :(.
> >
> >Could you explain why you need to add in the size of an address?
>
> It's not necessarily must be addr sizeof, it may be 1, but, I think,
> will be better, if current_source_end_addr will contain correct
> value for target.
What I'd like to understand is why (start_addr + size) is insufficient.
I.e, why do we need to add 1 or some other small value to compute the
correct ending address?
Kevin