This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] sim/h8300/compile.c: Fix formatting.


> Hi,
> 
> Attached is a patch to fix formatting.  Committed as obvious.
> 
> Kazu Hirata

Kazu, thanks!

I gather you did this by hand though:

+ 
       if((_dst+count)>=(cpu.memory+memory_size))

For GDB, there is an easier way.  Just run:

	$ cd src/sim/h8300
	$ ../../gdb/gdb_indent.sh compile.sh
	Not in GDB directory

Er, oops!  Hang on I'll just fix that.

AndrewV,

Don't forget the coding standard:

	http://www.gnu.org/prep/standards_toc.html

One thing I noticed is variables like ``_dst''.  The leading underscore 
shouldn't be used.

enjoy,
Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]