This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [patch] sim/h8300/compile.c: Fix formatting.
- From: Andrew Cagney <ac131313 at cygnus dot com>
- To: Kazu Hirata <kazu at cs dot umass dot edu>,Andrew Volkov <Andrew dot Volkov at transas dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Sat, 18 May 2002 15:43:25 -0400
- Subject: Re: [patch] sim/h8300/compile.c: Fix formatting.
- References: <20020518.074029.25910897.kazu@cs.umass.edu>
> Hi,
>
> Attached is a patch to fix formatting. Committed as obvious.
>
> Kazu Hirata
Kazu, thanks!
I gather you did this by hand though:
+
if((_dst+count)>=(cpu.memory+memory_size))
For GDB, there is an easier way. Just run:
$ cd src/sim/h8300
$ ../../gdb/gdb_indent.sh compile.sh
Not in GDB directory
Er, oops! Hang on I'll just fix that.
AndrewV,
Don't forget the coding standard:
http://www.gnu.org/prep/standards_toc.html
One thing I noticed is variables like ``_dst''. The leading underscore
shouldn't be used.
enjoy,
Andrew