This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFC/MI] Renumber enum mi_cmd_result
- From: Andrew Cagney <ac131313 at cygnus dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Fri, 17 May 2002 17:43:54 -0400
- Subject: Re: [RFC/MI] Renumber enum mi_cmd_result
- References: <Pine.GSO.4.33.0205171417280.2236-100000@makita.cygnus.com>
> Hi,
>
> I've been looking over Apple's MI changes, so expect to see quite a few
> questions/changes/patches/debates/documentation updates/etc in the coming
> weeks on MI.
>
> This simple patch renumbers enum mi_cmd_result so that it starts at one
> instead of zero. This is necessary because MI_CMD_DONE would be
> indistinguishable from an error condition (both would return zero to
> catch_errors).
>
> I have run the testsuite before and after this change, and it produces no
> differences.
>
> (Okay, this is almost too simple to leave by itself, but, gotta start
> somewhere!)
>
> Keith
>
> ChangeLog
> 2002-05-17 Keith Seitz <keiths@redhat.com>
>
> From Jim Ingham <jingham at apple dot com>:
> * mi-cmds.h (enum mi_cmd_result): Start numbering at one instead
> of zero so that errors can be distinguished from other status
> returns.
>
Keith,
Check catch_exceptions(). The whole catch_errors() argument problem has
been fixed. I'd consider a switch to catch_exceptions obvious and I can
see only one call.
Andrew