This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[RFC/MI] Renumber enum mi_cmd_result


Hi,

I've been looking over Apple's MI changes, so expect to see quite a few
questions/changes/patches/debates/documentation updates/etc in the coming
weeks on MI.

This simple patch renumbers enum mi_cmd_result so that it starts at one
instead of zero. This is necessary because MI_CMD_DONE would be
indistinguishable from an error condition (both would return zero to
catch_errors).

I have run the testsuite before and after this change, and it produces no
differences.

(Okay, this is almost too simple to leave by itself, but, gotta start
somewhere!)

Keith

ChangeLog
2002-05-17  Keith Seitz  <keiths@redhat.com>

        From Jim Ingham <jingham at apple dot com>:
        * mi-cmds.h (enum mi_cmd_result): Start numbering at one instead
        of zero so that errors can be distinguished from other status
        returns.

Patch
Index: mi/mi-cmds.h
===================================================================
RCS file: /cvs/src/src/gdb/mi/mi-cmds.h,v
retrieving revision 1.5
diff -p -r1.5 mi-cmds.h
*** mi/mi-cmds.h	6 Mar 2001 08:21:45 -0000	1.5
--- mi/mi-cmds.h	17 May 2002 21:14:43 -0000
***************
*** 27,34 ****
  enum mi_cmd_result
    {
      /* Report the command as ``done''.  Display both the ``NNN^done''
!        message and the completion prompt.  */
!     MI_CMD_DONE = 0,
      /* The command is still running in the forground.  Main loop should
         display the completion prompt. */
      MI_CMD_FORGROUND,
--- 27,36 ----
  enum mi_cmd_result
    {
      /* Report the command as ``done''.  Display both the ``NNN^done''
!        message and the completion prompt.  Start this at 1 so that
!        you can distinguish ALL these returns from the 0 of an error
!        in catch_errors. */
!     MI_CMD_DONE = 1,
      /* The command is still running in the forground.  Main loop should
         display the completion prompt. */
      MI_CMD_FORGROUND,


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]