This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] IA64 fix for breakpoints on L in MLX instruction bundles
- From: Kevin Buettner <kevinb at redhat dot com>
- To: Petr Sorfa <petrs at caldera dot com>, "gdb-patches at sources dot redhat dot com" <gdb-patches at sources dot redhat dot com>
- Date: Thu, 9 May 2002 09:56:17 -0700
- Subject: Re: [PATCH] IA64 fix for breakpoints on L in MLX instruction bundles
- References: <3CDAAB19.4780AA1F@caldera.com>
On May 9, 1:00pm, Petr Sorfa wrote:
> Patch for handling breakpoints on the L instruction type in an MLX
> bundle.
>
>
> 2002-05-09 Petr Sorfa (petrs@caldera.com)
>
> * ia64-tdep.c: Handle breakpoints on L instruction type
> in MLX instruction bundle by moving the breakpoint to
> the third slot (X instruction type) as L holds only data.
Approved, but I'd like you to fix a minor indentation issue prior
to committing it though...
> + if (slotnum == 1 && template_encoding_table[template][1] == L)
> + {
> + slotnum = 2;
> + }
This should look like this instead:
> + if (slotnum == 1 && template_encoding_table[template][1] == L)
> + {
> + slotnum = 2;
> + }
Or just:
> + if (slotnum == 1 && template_encoding_table[template][1] == L)
> + slotnum = 2;
Thanks,
Kevin