This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Tue, May 07, 2002 at 11:18:01AM -0400, Elena Zannoni wrote: > Is there any chance you could take a look at the sh5 patch I posted a > while back, and see if/how your patch integrates (in principle, at least)? > The patch is here: > http://sources.redhat.com/ml/gdb-patches/2002-02/msg00218.html I looked over this patch -- with my rename of "sh_abi" to "sh_osabi", I don't really see any conflict (SHcompact vs. SHmedia [32 vs 64] seems orthogonal to OS ABI variations -- sort of like ARM vs. Thumb and Linux vs. NetBSD). > About your patch, I would prefer if the switch on the os_number used > names instead of 0,1,2, is this possible? Same for this line: > + if (elfosabi == 0) ...also made these suggested changes, and submitted the patch that defines the constants to binutils for approval (err, did I follow protocol correctly in doing so?) Anyway, updated patch attached. OK to commit once the elf/common.h patch goes in? * sh-tdep.c (sh_osabi_names): Declare. (process_note_abi_tag_sections): New function. (get_elfosabi): Ditto. (sh_gdbarch_register_os_abi): Ditto. (sh_dump_tdep): Ditto. _initialize_sh_tdep): Use gdbarch_register to register sh_gdbarch_init and sh_dump_tdep. * config/sh/tm-sh.h (sh_osabi): Declare. (gdbarch_tdep): Add sh_osabi and osabi_name members. -- -- Jason R. Thorpe <thorpej@wasabisystems.com>
Attachment:
sh-abi-patch
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |