This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: Obvious fix in values.c?
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: Jim Ingham <jingham at apple dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Fri, 19 Apr 2002 18:58:37 -0400
- Subject: Re: Obvious fix in values.c?
- References: <6D0E546A-53DC-11D6-8B7C-00039379E320@apple.com>
On Fri, Apr 19, 2002 at 02:28:44PM -0700, Jim Ingham wrote:
> Do folks agree that this falls under the obvious fix rule? It doesn't
> seem safe to assume that all demangled names will contain a space (and
> in fact, gdb crashed on someone when the assumption was proved false...).
>
> 2002-04-19 Jim Ingham <jingham@apple.com>
>
> * values.c (value_headof): Don't assume all demangled names contain
> a space.
Could I please get you to solve this properly? Kill the one and only
use of this function in printcmd.c via value_from_vtable_info. If you
simply cast the pointer to a pointer to the proper base type, found via
value_rtti_type, this function can die. It should just work (and/or be
more useful than the current behavior).
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer