This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Testsuite tweak - properly bail out of asm-source.exp


If asm-source.exp detects that there is no support for assembly source
debugging on the selected target, it issues a warning to that effect:

if { "${asm-arch}" == "" } {
    gdb_suppress_entire_file "Assembly source test -- not implemented for this t
arget."
}

but then it goes on to run the tests anyway, and they all fail, often
with nasty error messages too.  Looking a bit lower, I see that one is
supposed to return after calling gdb_suppress_entire_file.  This patch
just adds a return to the if block.

zw

	* gdb.asm/asm-source.exp: Return after calling
	gdb_suppress_entire_file.

===================================================================
Index: testsuite/gdb.asm/asm-source.exp
--- testsuite/gdb.asm/asm-source.exp	8 Apr 2002 00:01:06 -0000	1.21
+++ testsuite/gdb.asm/asm-source.exp	18 Apr 2002 01:29:59 -0000
@@ -65,6 +65,7 @@ if [istarget "xstormy16-*-*"] then {
 }
 if { "${asm-arch}" == "" } {
     gdb_suppress_entire_file "Assembly source test -- not implemented for this target."
+    return;
 }
 
 # Watch out, we are invoking the assembler, but the testsuite sets multilib


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]