Re: [patch/rfc] Delete write_fp() and friends

[Michael Snyder <msnyder at redhat dot com>]

Andrew Cagney wrote:
> 
> > On Mar 28, 10:28am, Michael Snyder wrote:
> >
> >
> >> > Well, almost, I left dwarf2cfi.c's write_fp() as is - someone might be
> >> > interested in the code.
> >> >
> >> > Assuming no issues are raised, and my builds come back clean, I'll
> >> > commit it next week.
> >
> >>
> >> So what should calls to write_fp be replaced with?
> >
> >
> > It looks to me like there was only one call to write_fp() and that
> > occurred in sparc-tdep.c.  Andrew replaced that call with a call to
> > write_register().
> 
> I need to examine that a bit more carefully though.
> 
> > But, ahem, it would've been nice for Andrew to tell us this in the
> > prefatory text preceding the patch.
> 
> True, it was intentional - to see who was awake.  I figured that a patch
> to delete write_fp() was going to be examined very very carefully :-)

If no one but Sparc is using it, I'm not very worried
(as long as you take care of sparc).