This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Let dwarf2 CFI's execute_stack_op be used outside of CFI


> 
> Whoops.
> You're right.
> I must have merged it while on crack or something.
> I *meant* to add the frame argument, and only require *either* the 
> context argument (Which is what it currently takes, a CFA context)  or the 
> frame, but it looks like I messed up.
> 
> What it *should* look like is closer to the one from the WIP i sent. It 
> should call get_saved_register with the frame argument if the context is 
> null, or get_reg with the context argument if the context is not null.

That is what I was asking

I wrote:

>> Shouldn't the dwarf2 location expression evaluator be separated out 
>> (dwarf2loc?) and be parameterized with both the frame it is to operate 
>> within and the expression it is to evaluate. 

You wrote:

> Yeah, so?
> I'm doing this incrementally.
> The first step is adding an external entry point, then moving it outside 
> of dwarf2cfi.c, then modifying it to take a struct frame info, etc.
> I'm trying to do this without breaking anything.
> It currently *is* parameterized with both the frame and expression.  The 
> problem is that the frame it expects isn't a "struct frame_info", it's a 
> dwarf2 frame context.

Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]