This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: PATCH: new "void" memory region attribute
- From: Michael Snyder <msnyder at redhat dot com>
- To: Andrew Cagney <ac131313 at cygnus dot com>
- Cc: Greg McGary <gkm at kayak dot mcgary dot org>, gdb-patches at sources dot redhat dot com
- Date: Wed, 13 Feb 2002 19:20:59 -0800
- Subject: Re: PATCH: new "void" memory region attribute
- Organization: Red Hat, Inc.
- References: <msg044zz73.fsf@mcgary.org> <3C6B2DB1.9060304@cygnus.com>
Andrew Cagney wrote:
>
> > enum mem_access_mode
> > {
> > - MEM_RW, /* read/write */
> > - MEM_RO, /* read only */
> > - MEM_WO /* write only */
> > + MEM_VOID = 0,
> > + MEM_READ = 1,
> > + MEM_WRITE = 2,
> > + MEM_RW = MEM_READ | MEM_WRITE,
> > };
> >
>
> Greg, I'm just wondering why this part change? Wouldn't just adding a
> MEM_VOID entry have been easier?
No, it's because (attr != MEM_RO) is no longer a sufficient test
to see if a section is writeable. There are now two modes that are
not writeable -- MEM_RO and MEM_VOID. He could have made the tests
more complex, he simply chose to do it this way instead.