This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: extra doco
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: Andrew Cagney <ac131313 at cygnus dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Mon, 4 Feb 2002 17:42:53 -0500
- Subject: Re: extra doco
- References: <3C5E22EC.70605@cygnus.com>
On Mon, Feb 04, 2002 at 12:58:04AM -0500, Andrew Cagney wrote:
> Daniel,
>
> Can I suggest adding comments to:
>
> {
> /* The name of this register - NULL for pad entries. */
> const char *name;
>
> /* The offset (in bits) of the value of this register in the buffer. */
> int offset;
>
> /* The size (in bits) of the value of this register, as transmitted. */
> int size;
> };
>
>
> explaining the constraints that apply - %8 due to two hex digits and
> %byte due to the need to represent each register in memory.
Sure, done. I'm still not convinced that the restrictions are 'right',
but we can argue about that when we have a specific system that wants
differently.
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
Index: regformats/regdef.h
===================================================================
RCS file: /cvs/src/src/gdb/regformats/regdef.h,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- regdef.h 2002/02/01 22:05:28 1.1
+++ regdef.h 2002/02/04 22:41:36 1.2
@@ -23,6 +23,11 @@
/* The name of this register - NULL for pad entries. */
const char *name;
+ /* At the moment, both of the following bit counts must be divisible
+ by eight (to match the representation as two hex digits) and divisible
+ by the size of a byte (to match the layout of each register in
+ memory). */
+
/* The offset (in bits) of the value of this register in the buffer. */
int offset;