This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH RFA] Zap EXTRA_FRAME_INFO for ARM target


> Thinking about it Jason was correct in taking this aproach (I suspect 
>> I've done this with other targets).  A patch making the single 
>> independant change of eliminating EXTRA_FRAME_INFO is mechanical, and as 
>> such, can be treated as obvious.
> 
> 
> I think it depends upon the target.  For ARM, nearly all of the
> changes were mechanical, but the ARM target has some pecularities
> which required some care.


If someone is multi-arching a target and accidently breaks it (even 
though before/after tests showed no problems) then I consider that 
acceptable risk.  (It is a testsuite bug right :-)

If a change is more technical then tableing it for a few days wouldn't 
hurt.  However, in the end I think us as maintainers need to show 
confidence in the person doing the work and give them a free hand.

enjoy,
Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]