This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: possible bogus isnative check in list.exp


Fred Fish wrote:
> 
> Currently list.exp has a check for isnative and suppresses a test if
> isnative is true.  As it turns out, this test works fine in the
> simulator.  Perhaps the test is obsolete, or perhaps it really should
> only be suppressed for remote targets using an "is_remote" check.
> 
> In any case, this patch would remove the check if that is the right
> solution:
> 
> Index: list.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/list.exp,v
> retrieving revision 1.3
> diff -r1.3 list.exp
> 98,103c98
> <     if ![isnative] {
> <       runto_main;
> <       unsupported "list default lines around main";
> <     } else {
> <       gdb_test "list" "(1\[ \t\]+#include \"list0.h\".*10\[ \t\]+x = 0;|2.*11\[ \t\]+foo .x\[+)\]+;)" "list default lines around main"
> <     }
> ---
> >     gdb_test "list" "(1\[ \t\]+#include \"list0.h\".*10\[ \t\]+x = 0;|2.*11\[ \t\]+foo .x\[+)\]+;)" "list default lines around main"
> 
> Comments?

I can't understand why this test would depend on native/remote/sim.
It should work for all of them, no?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]