This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [patch]: 2 more needed changes for sim-fpu.c & psim
- From: Andrew Cagney <ac131313 at cygnus dot com>
- To: matthew green <mrg at cygnus dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Sat, 15 Dec 2001 00:00:51 -0500
- Subject: Re: [patch]: 2 more needed changes for sim-fpu.c & psim
- References: <7.1008389753@cygnus.com>
> I'm puzzled by some of the includes. Well "defs.h" to be honest. I
> know the PPC has a nasty hack so that it can access the GDB register
> names but I'm not sure that main.c - a standalone program - should
> include "defs.h".
>
> main.c doesn't need defs.h, right.
>
> I think the error stuff should go to stderr.
>
> hmm, i choose stdout because the "error" function a couple of pages
> above does the same...
Ah, ok then.
> From memory, for the sim_call.c, the error stuff should go to the callback.
>
> OK, i've done this.. how's this?
>
>
>
> * main.c: Include "bfd.h", "callback.h" and "remote-sim.h".
> (sim_io_error): New function.
> * sim_calls.c: (sim_io_error): New function.
>
Yes fine.
Thanks!
Andrew