This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA: Hopefully last one of these init_types() tweaks
- From: Elena Zannoni <ezannoni at cygnus dot com>
- To: fnf at redhat dot com
- Cc: gdb-patches at sources dot redhat dot com
- Date: Sun, 9 Dec 2001 14:16:48 -0500
- Subject: Re: RFA: Hopefully last one of these init_types() tweaks
- References: <200112091815.fB9IF9e02565@fishpond.ninemoons.com>
Fred Fish writes:
> Found one more case where init_types could simply be called with the
> right flag bits rather than setting them after the fact. I believe
> this is the last one of these, except for one in java_lookup_class()
> that is in code that is commented out and is broken code anyway.
>
> -Fred
Yes, please commit it.
Thanks
Elena
>
> 2001-12-09 Fred Fish <fnf@redhat.com>
>
> * mdebugread.c (cross_ref): Pass TYPE_FLAG_STUB to init_type()
> rather than setting it after the type is created.
>
> Index: mdebugread.c
> ===================================================================
> RCS file: /cvs/cvsfiles/devo/gdb/mdebugread.c,v
> retrieving revision 2.88
> diff -c -p -r2.88 mdebugread.c
> *** mdebugread.c 2001/11/10 03:02:19 2.88
> --- mdebugread.c 2001/12/08 21:20:59
> *************** cross_ref (int fd, union aux_ext *ax, st
> *** 4234,4241 ****
> if (rf == -1)
> {
> *pname = "<undefined>";
> ! *tpp = init_type (type_code, 0, 0, (char *) NULL, current_objfile);
> ! TYPE_FLAGS (*tpp) |= TYPE_FLAG_STUB;
> return result;
> }
>
> --- 4234,4240 ----
> if (rf == -1)
> {
> *pname = "<undefined>";
> ! *tpp = init_type (type_code, 0, TYPE_FLAG_STUB, (char *) NULL, current_objfile);
> return result;
> }
>