This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [patch] i386go32_frame_saved_pc()
- From: Pierre Muller <muller at cerbere dot u-strasbg dot fr>
- To: gdb-patches at sources dot redhat dot com
- Date: Tue, 04 Dec 2001 16:23:01 +0100
- Subject: Re: [patch] i386go32_frame_saved_pc()
At 19:27 02/12/2001 , Andrew Cagney a écrit:
>Hello,
>
>-Werror was flaging an undeclared read_memory_integer() for the go32 target. This converts that macro into a function, which needs to be done anyway :-)
>
> Andrew
>
>
>2001-12-02 Andrew Cagney <ac131313@redhat.com>
>
> * i386-tdep.c (i386go32_frame_saved_pc): New function.
> * config/i386/tm-go32.h (i386go32_frame_saved_pc): Declare.
> (FRAME_SAVED_PC): Redefine to i386go32_frame_saved_pc.
>
>Index: i386-tdep.c
>===================================================================
>RCS file: /cvs/src/src/gdb/i386-tdep.c,v
>retrieving revision 1.46
>diff -p -r1.46 i386-tdep.c
>*** i386-tdep.c 2001/11/18 22:14:13 1.46
>--- i386-tdep.c 2001/12/02 18:23:15
>*************** i386_frame_saved_pc (struct frame_info *
>*** 508,513 ****
>--- 508,519 ----
> return read_memory_unsigned_integer (frame->frame + 4, 4);
> }
>
>+ CORE_ADDR
>+ i386go32_frame_saved_pc (struct frame_info *frame)
>+ {
>+ return read_memory_integer (frame->frame + 4, 4);
>+ }
>+
Just one small question, shouldn't it also be an
read_memory_unsigned_integer here ?
a CORE_ADDR for i386 is always unsigned, no ?
Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller@ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07 Fax : (33)-3-88-41-40-99