Re: [RFA] W.I.P. AltiVec ppc registers support.

[Elena Zannoni <ezannoni at cygnus dot com>]

Kevin Buettner writes:
 > On Nov 29,  4:59pm, Elena Zannoni wrote:
 > 
 > >  > With regard to
 > >  > 
 > >  > > Index: config/powerpc/nm-linux.h
 > >  > [...]
 > >  > > +#define FETCH_INFERIOR_REGISTERS
 > >  > 
 > >  > I think this is a good thing.  It *might not* be strictly necessary
 > >  > for adding AltiVec support via PEEKUSER / POKEUSER, but it does give
 > >  > us more control.  Also doing this allows us to clean up the code in other
 > >  > ways.  E.g, the following bit from config/powerpc/nm-linux.h can be
 > >  > removed:
 > >  > 
 > >  > >  extern int ppc_register_u_addr (int, int);
 > >  > >  #define REGISTER_U_ADDR(addr, blockend, regno) \
 > >  > >          (addr) = ppc_register_u_addr ((blockend),(regno));
 > >  > 
 > >  > This in turn means that ppc_register_u_addr() can be made static
 > >  > and that the ``ustart'' parameter can be removed.  All calls to
 > >  > register_addr() (in your new code) in ppc-linux-nat.c should be
 > >  > changed to invoke ppc_register_u_addr() directly.
 > >  > 
 > > 
 > > Unfortunately not. I thought the same, until I remembered about core
 > > file debugging. That function is called by fetch_core_registers() in
 > > core-aout.c.
 > 
 > Hmm... I wonder if Linux/PPC even needs this function in core-aout.c.
 > Daniel J. is the expert on this stuff.  Daniel, doesn't Linux/PPC use
 > core-regset.c instead?
 > 

Whoops, yes, you are right. False alarm.

Elena


 > Kevin