This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [RFA] Yet more V3 C++ tweaks


Patch #2 to templates.exp is not approved.

This patch does not apply on top of Patch #1 to templates.exp (which is
approved).  Patch #1 and patch #2 change the same line in different ways.
Thus, I can't test the actual text that is meant to be in the file if
both patches were applied.

Can you please combine #1 and #2 and submit as one patch, or go ahead
and commit #1 and then submit #2 against the new version of templates.exp.

Meanwhile I am pending the third patch to catch some sleep.

For reference:

  patch #1  approved  

	* gdb.c++/templates.exp: Replace "const &" with "const ?&", 
	making the whitespace optional.  Also replace "(void) with
	"((void|)), making the keyword "void" optional.

  patch #2  rejected

        * gdb.c++/templates.exp: Replace "void \\*" with "void ?\\*",
        making the whitespace optional.  Argument for "new" may be
        "unsigned" as well as "unsigned int/long".
        
  patch #3  pending review

	* gdb.c++/templates.exp (test_template_breakpoints): 
	If we get an overload menu, but it does not match what 
	we expect, we still need to issue the "cancel" command.

Michael C


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]