This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] Add mips_software_single_step
- To: Andrew Cagney <ac131313 at cygnus dot com>
- Subject: Re: [RFA] Add mips_software_single_step
- From: Daniel Jacobowitz <dmj+ at andrew dot cmu dot edu>
- Date: Thu, 5 Jul 2001 15:05:11 -0700
- Cc: gdb-patches at sources dot redhat dot com
- References: <20010704115630.A16310@nevyn.them.org> <3B44E116.4070009@cygnus.com>
On Thu, Jul 05, 2001 at 05:50:14PM -0400, Andrew Cagney wrote:
> > This function's pretty straightforward; the Linux port uses it. Ok to
> > commit?
>
>
> How does the linux port use it? As a tweek to the multi-arch vector or
> as a macro/function? If the former then it should be static, if the
> latter than a declaration in mips-tdep.h or tm-mips.h (?) is needed.
As a macro:
#define SOFTWARE_SINGLE_STEP_P() 1
extern void mips_software_single_step (unsigned int, int);
#define SOFTWARE_SINGLE_STEP(sig,bp_p) mips_software_single_step (sig, bp_p)
I'm sensing that this belongs in the multi-arch vector, though. I'll
change that.
The question this raises is how to do it. I'd rather do it in
mips-linux-tdep.c than mips-tdep.c, and mips-tdep shouldn't know we're
compiling for a Linux target (it already does, via MIPS_DEFAULT_ABI,
but I'll address that in a bit). How can I modify the gdbarch vector
in a second place?
> The function is almost ok. It just needs to be updated to meet GDB's
> current coding conventions (ISO-C, indentation).
Right. I'll do that too.
> With regard to the linux code, you should probably look over
> http://sources.redhat.com/gdb/ari/ and check any new code for potential
> regressions or errors. Just remember to ignore any of the warnings :-)
I think I'm OK on most of those; I'll go over it again later.
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer