This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [RFC] if (INNER_THAN (read_sp(), step_sp - 16))


> Well it can't be a (ugh) #ifdef :-)
> 
> 
> Not even to temporarily circumvent a known bug?


Not even to tempoarily circumvent a known bug.

> I understand your objection (multi-arch, if not general
> distaste), but there are lots of ifdefs in infrun.c already...
> 
> FYI, I was thinking along the lines of
> 	(currently_stepping (ecs)
> #ifdef TM_i386SOL2_H
> 	&& !(step_range_end
> 	    && INNER_THAN (read_sp (), (step_sp - 16)))
> #endif
> 	));
> 
> which would preserve the behavior on x86 solaris, while
> protecting the rest of the world until Peter can come up
> with a better implementation.


I honestly think it would be better to revert PeterS's N year old change 
and file a PR.

	Andrew




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]