This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Rewriting the type system


Andrew Cagney <ac131313@cygnus.com> writes:

>> Hell, the simple bcache change i submitted last year (updating the
>> starting constant, fix the indenting) still hasn't
>> been reviewed.
> 
> 
> This patch?
Yup.

> 
> I'm suprized you didn't take the initiative here and check it in as an
> obvious fix.

Really?
It's in Jim's area.
Jim tells me my patches aren't correct. 
Don't you think "taking the initiative" and just up and checking it in would
step on his toes a little bit?
Believe it or not, I tried to avoid doing this when possible, which it
wasn't always in order to get stuff done.
We also had no clear ruling on the obvious fix rule yet, anyway.

Besides, if it's an obvious fix, why didn't he just take a few minutes to
look it over when it arrived in his inbox (you'll note the original
message was copied to him), and reply "looks okay"? Since if it's
obvious, it shouldn't take him more than probably 1 or 2 minutes to
look over a 20-30 line patch.

Just like a software project becomes late one day at a time, GDB is
improved one patch at a time.
If some of you maintainer guys and gals (i'm no longer a maintainer,
so it's not "we") ignore small patches (and i'm not implying any one
particular person does), 
A. You won't get the effect a piling up of small improvements has.
B. You won't spur the people who made the small changes to make
   larger, more ambitious ones.

I haven't touched the bcache since submitting that patch, and getting
no response. It's not because the bcache is perfect. It's because who
the heck wants to make large changes to anything if they'll just go
off into a void?

> 
> 
> 	Andrew
> 

-- 
"I have two very rare photographs.  One is a picture of Houdini
locking his keys in his car.  The other is a rare photograph of
Norman Rockwell beating up a child.
"-Steven Wright


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]