Re: [PATCH RFA] breakpoint.c: Pass breakpoint type to set_raw_breakpoint()

[Fernando Nasser <fnasser at redhat dot com>]

Kevin Buettner wrote:
> 
> On May 11,  1:27pm, Fernando Nasser wrote:
> 
> > > Kevin, I like it, but I noticed that set_raw_breakpoint is not static.
> > > It was made extern in 1998, and is used by gdbtk-cmds.c.
> > >
> > > Can you check to see if that call needs a bp_type argument, and if that
> > > call can't be eliminated, maybe you should add a prototype to breakpoint.h.
> >
> > I believe it can be made static now.  I don't think anyone should be
> > using it outside breakpoint.c.
> >
> > Keith, does your new gdbtk-bp.c uses this function?
> 
> Does Keith have a version that's not checked in yet?
> 
> I did an update a moment ago and notice that set_raw_breakpoint is
> still used by gdbtk-bp.c.  Here's a telling comment from this file...
> 
>     /*
>      * These are routines we need from breakpoint.c.
>      * at some point make these static in breakpoint.c and move GUI code there
>      */
> 
>     extern struct breakpoint *set_raw_breakpoint (struct symtab_and_line sal);
>     extern void set_breakpoint_count (int);
>     extern int breakpoint_count;
> 
> I will adjust the set_raw_breakpoint() calls in gdbtk-bp.c to pass the
> extra argument.  I'll let Keith (or someone else more familiar with
> these issues than I am) decide whether a prototype ought to be added
> to breakpoint.h or if the calls in gdbtk-bp.c can be eliminated (thus
> allowing breakpoint.c to make set_raw_breakpoint() static again).
> 

Fair enough.

Thanks.

P.S.: Thank you Michael Snyder, for the heads up.  My SourceNav got the
reduced gdbtk-cmds.c where this call was before but I did not yet add
the new files where the call is now, so I was not seeing the call in
gdbtk land.


-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9