This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH] Add support for tracking/evaluating dwarf2 location expressions
- To: Andrew Cagney <ac131313 at cygnus dot com>
- Subject: Re: [PATCH] Add support for tracking/evaluating dwarf2 location expressions
- From: Daniel Berlin <dan at www dot cgsoftware dot com>
- Date: Fri, 6 Apr 2001 15:10:01 -0400 (EDT)
- cc: Daniel Berlin <dberlin at redhat dot com>, <gdb-patches at sources dot redhat dot com>
On Fri, 6 Apr 2001, Andrew Cagney wrote:
> > > value_ptr stack;
> > > Is there a constant for this? A quick glance at decode_locdesc() and it
> > > has the same hardwired constant.
> > Nobody has ever produced location expressions that need more.
> The problem typically isn't with what people are doing intentionally but
> rather unintentionally. The code opens the way for an input file to
> cause gdb to overflow a buffer and trash its stack.
Well, as I said, it will trash GCC as well, since they do no range
checking, and have the exact same limit.
But i'll range check it, just the same.
> Since we're trying to lessen the likelyhood of GDB corrupting its stack
> and dumping core, I think the code should include some sort of stack
> range check.
As you wish, done in the latest version.
I moved it all into dwarf2eval.c as well.