This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] Revised C++ ABI abstraction patches
- To: Jim Blandy <jimb at cygnus dot com>
- Subject: Re: [RFA] Revised C++ ABI abstraction patches
- From: Andrew Cagney <ac131313 at cygnus dot com>
- Date: Thu, 15 Mar 2001 16:45:54 -0500
- Cc: Michael Elizabeth Chastain <chastain at cygnus dot com>,gdb-patches at sources dot redhat dot com
- References: <200103151850.KAA30796@bosch.cygnus.com> <nplmq63lb6.fsf@zwingli.cygnus.com>
Jim Blandy wrote:
>
> Michael Elizabeth Chastain <chastain@cygnus.com> writes:
> > Lightly proofread, no obvious errors found.
>
> Great. That means all the bugs still there are non-obvious, and will
> take a long time to find. Just make my day, will you. (Thanks.)
>
> > I would prefer constructor_prefix_p et al to be real functions rather
> > than macros. When I single-step code in gdb, it's a lot easier to follow
> > real functions than macros.
>
> I agree completely. But it is not the standard practice (see target.h
> and elsewhere) and others don't seem to mind. So I reined in my prima
> donna urges and left them as macros.
Standard pratice is to use functions. Per the thread on the
xfer_memory() change - target.h will be fixed :-)
enjoy,
Andrew