This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] fix child_xfer_memory in hppah-nat.c
Eli Zaretskii wrote:
>
> > Date: Mon, 5 Feb 2001 13:18:14 -0500
> > From: Christopher Faylor <cgf@redhat.com>
> >
> > Here are the lines from configure.in:
> >
> > # NOTE: Don't add -Wall or -Wunused, they both include
> > # -Wunused-parameter which reports bogus warnings.
> >
> > The TODO has some words, too:
> >
> > Frequently requested but not approved requests.
> >
> > --
> >
> > Eliminate unused argument warnings using ATTRIBUTE_UNUSED.
> >
> > The benefits on this one are thought to be marginal - GDBs design
> > means that unused parameters are very common. GCC 3.0 will also
> > include the option -Wno-unused-parameter which means that ``-Wall
> > -Wno-unused-parameters -Werror'' can be specified.
> >
> >
> > >Several files in the CVS use ATTRIBUTE_UNUSED (not surprisingly,
> > >go32-nat.c is one of them ;-). So I wonder what is the current say-so
> > >on this matter.
> >
> > I specifically added some of these to win32-nat.c, too, not too long ago.
> > I do remember the discussion now. I can't say that I agree with it,
> > but I remember it.
> >
> > It looks like at least one discussion is here:
> >
> > http://sources.redhat.com/ml/gdb/2000-q1/msg00826.html
>
> Thanks for the pointers.
>
> However, after reading those, I'm still unsure what, if anything,
> should I do with ATTRIBUTE_UNUSED in files I'm responsible for.
Nothing! You've plenty of other things to do above and beyond worrying
about them. Just don't be suprised if someone some day submits a patch
to eliminate them (like chris just did for a bunch of PTRs).
Andrew