This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFC: Patch to allow compilation by Sun cc
Michael Snyder wrote:
> > Michael, just omit anthing to do with software_single_step. My patch
> > will fix it anyway.
>
> Yeah, but your patch isn't ready, and this one is.
> Any harm in checking this one in in the interim?
FYI, the reason I'd like the software_single_step() bit precluded is
because of the cast, not because of the patch conflict (I can live with
that).
Yes, I'm being unfortunatly picky about the cast because I don't want to
encourage a situtation where people gag compiler warnings by adding even
more layers of duct tape and spatfiller. (which is all somewhat ironic
given several recent patches I've proposed involving casts :-).
BTW, this isn't the first time I've seen this patch. Andrei Petrov
<and@genesyslab.com> also posted essentially the same change so both
might as well get credit :-). The first submition was unfortunatly held
up (and then burried) while its status with respect to needing an
assignment was clarified. That is how I know Paul Hilfinger's version
of the patch doesn't need an assignment :-)
enjoy,
Andrew