Re: [PATCH]: memory region attributes

[Jeff Holcomb <jeffh at redhat dot com>]

On 23 Jan 2001, J.T. Conklin wrote:

> Since these changes have been on the table for a few months with no
> objections, I'm going to use my newfound status to commit them.
> 
> This shouldn't cause any problems or undue overhead when no memory
> regions are defined.  In the past, I've run this through the test-
> suite with no regressions.
> 
> Within a week or so, I'll be proposing a remote protocol/remote.c
> change to support the memory access width attribute.

I'm no longer able to build on solaris2.5 after this change.  Looks like 
sol-thread.c needs to be updated also?

gcc -c -g -O2    -I. -I/home/jeffh/sources/src/gdb -I/home/jeffh/sources/src/gdb/config -DHAVE_CONFIG_H -I/home/jeffh/sources/src/gdb/../include/opcode -I/home/jeffh/sources/src/gdb/../readline/.. -I../bfd -I/home/jeffh/sources/src/gdb/../bfd  -I/home/jeffh/sources/src/gdb/../include -I../intl -I/home/jeffh/sources/src/gdb/../intl  -DUI_OUT=1 -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith  /home/jeffh/sources/src/gdb/sol-thread.c
/home/jeffh/sources/src/gdb/sol-thread.c: In function `sol_thread_xfer_memory':
/home/jeffh/sources/src/gdb/sol-thread.c:778: warning: passing arg 5 of pointer to function from incompatible pointer type
/home/jeffh/sources/src/gdb/sol-thread.c:778: too few arguments to function
/home/jeffh/sources/src/gdb/sol-thread.c:781: warning: passing arg 5 of pointer to function from incompatible pointer type
/home/jeffh/sources/src/gdb/sol-thread.c:781: too few arguments to function
/home/jeffh/sources/src/gdb/sol-thread.c: In function `rw_common':
/home/jeffh/sources/src/gdb/sol-thread.c:1064: warning: passing arg 5 of pointer to function from incompatible pointer type
/home/jeffh/sources/src/gdb/sol-thread.c:1064: too few arguments to function
/home/jeffh/sources/src/gdb/sol-thread.c:1066: warning: passing arg 5 of pointer to function from incompatible pointer type
/home/jeffh/sources/src/gdb/sol-thread.c:1066: too few arguments to function
/home/jeffh/sources/src/gdb/sol-thread.c: In function `sol_find_new_threads':
/home/jeffh/sources/src/gdb/sol-thread.c:1432: warning: implicit declaration of function `procfs_find_new_threads'
/home/jeffh/sources/src/gdb/sol-thread.c: In function `init_sol_thread_ops':
/home/jeffh/sources/src/gdb/sol-thread.c:1567: warning: assignment from incompatible pointer type
/home/jeffh/sources/src/gdb/sol-thread.c: In function `init_sol_core_ops':
/home/jeffh/sources/src/gdb/sol-thread.c:1615: warning: assignment from incompatible pointer type

Thanks.

--
Jeff Holcomb
jeffh@redhat.com
GDB Engineering
Red Hat, Inc.