Re: [RFA] Demangled minsym hash table broken

[Michael Snyder <msnyder at cygnus dot com>]

Daniel Berlin+list.gdb-patches wrote:
> 
> Chris Faylor <cgf@cygnus.com> writes:
> 
> >
> > Peter Schauer submitted a patch a while ago when he discovered this.
> >
> > It's here:  http://sourceware.cygnus.com/ml/gdb-patches/2000-q1/msg00869.html
> >
> > I don't know if your patch is similar but we should probably go with the
> > simplest solution...
> >
> 
> I'll work up some testcases and commit his patch, along with some more
> C++ support fixes i've been working on (Should help a lot with the
> people still using STABS).

Daniel, is this the result?

        * minsyms.c (add_minsym_to_demangled_hash_table): New function.
        (install_minimal_symbols): Fix demangled symbol problems caused
by
        using add_minsym_to_hash_table for the demangled names, which is

Just a small nit: this is a static function in minsyms.c, yet
it's declared extern in symtab.h.  Gives a new -Wall warning.

				Michael