This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: RFA: minor watchpoint code cleanup



> Yes, yes, but does anyone have comments on my little patch?  :)

Sorry, you are right.

I think this patch is a good idea, but I have one minor suggestion.
Instead of these two lines:

!       size = (len > 4) ? 4 : len;
!       size = size_try_array[size - 1][align];

I would suggest to write this:

	size = size_try_array[len > 4 ? 3 : len - 1][align];

The reason is that IMHO we should avoid making a variable (`size')
serve two puproses at the same time.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]