This is the mail archive of the
gdb-patches@sourceware.cygnus.com
mailing list for the GDB project.
Re: [PATCH] remote_detach() and inferior_pid
- To: Fernando Nasser <fnasser at cygnus dot com>
- Subject: Re: [PATCH] remote_detach() and inferior_pid
- From: Elena Zannoni <ezannoni at cygnus dot com>
- Date: Thu, 17 Feb 2000 16:26:33 -0500 (EST)
- Cc: Elena Zannoni <ezannoni at cygnus dot com>, Andrew Cagney <ac131313 at cygnus dot com>, Jim Kingdon <kingdon at redhat dot com>, gdb-patches at sourceware dot cygnus dot com
- References: <14505.29243.656290.516276@kwikemart.cygnus.com><bd7pynspv.fsf@rtl.cygnus.com><38ABADEC.F0320CCB@cygnus.com><14508.25526.45779.825197@kwikemart.cygnus.com><38AC660E.7D898F58@cygnus.com>
Fernando Nasser writes:
> Elena Zannoni wrote:
> >
> > OK, all in agreement then. I'll add a generic_mourn_inferior() call in
> > there. New patch follows. OK to check in?
> >
>
> Hum, shouldn't we just change the calls to pop_target() by calls to
> remote_mourn() and remote_asynch_mourn() instead?
>
True, I thought about that, but remote_mourn / remote_async_mourn call
unpush_target(), instead of pop_target(). I am not sure if that's an
important difference, or just a coincidence.
Elena
> Fernando
>
>
> > Index: remote.c
> > ===================================================================
> > RCS file: /cvs/cvsfiles/devo/gdb/remote.c,v
> > retrieving revision 1.269
> > diff -c -r1.269 remote.c
> > *** remote.c 2000/02/02 07:47:45 1.269
> > --- remote.c 2000/02/17 21:06:46
> > ***************
> > *** 2124,2129 ****
> > --- 2124,2130 ----
> > remote_send (buf, PBUFSIZ);
> >
> > pop_target ();
> > + generic_mourn_inferior ();
> > if (from_tty)
> > puts_filtered ("Ending remote debugging.\n");
> >
> > ***************
> > *** 2149,2154 ****
> > --- 2150,2156 ----
> > SERIAL_ASYNC (remote_desc, NULL, 0);
> >
> > pop_target ();
> > + generic_mourn_inferior ();
> > if (from_tty)
> > puts_filtered ("Ending remote debugging.\n");
> > }
>
> --
> Fernando Nasser
> Red Hat - Toronto E-Mail: fnasser@cygnus.com
> 2323 Yonge Street, Suite #300 Tel: 416-482-2661 ext. 311
> Toronto, Ontario M4P 2C9 Fax: 416-482-6299
>