Re: Patch for i386-linux-nat.c

[Andreas Jaeger <aj at suse dot de>]

>>>>> Mark Kettenis writes:

 > Hi Jim,
 > Here is a patch for i386-linux-nat.c.  The main reason for the patch
 > is to change gregset_t and fpregset_t to elf_gregset_t and
 > elf_fpregset_t.  There were two different definitions of gregset_t and
 > fpregset_t on Linux, which were quite different from each other.  The
 > next glibc (version 2.1.3) will finaly put an end to this braindamage,
 > but this will break GDB.

 > While hacking on the file I noticed that there were quite a number of
 > inconsistencies in the comments and names of variables.  I've gone
 > over all the comments and rewritten most of them to describe in a more
 > precise way what they do and to use more consistent terminology.  I
 > know gratitious reformatting is frowned upon, but I honestly think
 > that this patch makes the file a lot easier to read.

Could somebody apply the patch, please?

Without it I get with the current CVS version and glibc 2.1.3pre3 this
error:

/opt/gcc-2.95/bin/gcc -c -g -O2 -W -Wall    -I. -I../../cvs/gdb/gdb -I../../cvs/gdb/gdb/config -DHAVE_CONFIG_H -I../../cvs/gdb/gdb/../include/opcode -I../../cvs/gdb/gdb/../readline/.. -I../bfd -I../../cvs/gdb/gdb/../bfd  -I../../cvs/gdb/gdb/../include -I../intl -I../../cvs/gdb/gdb/../intl -I../../cvs/gdb/gdb/tui  -Wimplicit -Wreturn-type -Wcomment -Wformat -Wparentheses -Winline  ../../cvs/gdb/gdb/i386-linux-nat.c
../../cvs/gdb/gdb/i386-linux-nat.c: In function `convert_to_gregset':
../../cvs/gdb/gdb/i386-linux-nat.c:124: warning: unused parameter `gdb_regs'
../../cvs/gdb/gdb/i386-linux-nat.c: In function `fetch_regs':
../../cvs/gdb/gdb/i386-linux-nat.c:159: warning: unused variable `regno'
../../cvs/gdb/gdb/i386-linux-nat.c: In function `store_regs':
../../cvs/gdb/gdb/i386-linux-nat.c:178: warning: unused variable `regno'
../../cvs/gdb/gdb/i386-linux-nat.c: In function `supply_fpregset':
../../cvs/gdb/gdb/i386-linux-nat.c:215: request for member `st_space' in something not a structure or union
../../cvs/gdb/gdb/i386-linux-nat.c:217: request for member `cwd' in something not a structure or union
../../cvs/gdb/gdb/i386-linux-nat.c:218: request for member `swd' in something not a structure or union
../../cvs/gdb/gdb/i386-linux-nat.c:219: request for member `twd' in something not a structure or 
[...]

Mark's patch fixes the problem for me.

Thanks,
Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.rhein-neckar.de