Re: [patch] Add start of mips32/mips64 support to sim/mips/mips.igen

[cgd at sibyte dot com (Chris G. Demetriou)]

cgd@sibyte.com (Chris G. Demetriou) writes:
> > To expand on this one.  I've two concerns.
> > 
> > 	o	I'd like to see a patch tabled
> > 		that adds the full mips32/mips64 ISA.
> > 
> > 		I think a new ISA should be added
> > 		as a single patch and not as an
> > 		incremental set of changes.
> 
> OK.  Having worked in the other tools, my inclination was stepwise
> refinement.
> 
> We can certainly do this if you are so inclined.  Would you prefer:
> 
> (a) 1 patch which adds MIPS V, MIPS32, and MIPS64 at once, or
> 
> (b) 1 patch for each.
> 
> I think if the goal is to do "one patch that just does it," I'd prefer
> the former, because it means a lot less duplication of effort.


Actually, I think I'd like to change my plan of action a bit.

Going forward, I think I'd like to:

(1) clean up the model stuff that I changed in my diff that I sent
in (but not adding mipsV, mips32, or mips64 for now).

(2) clean up several little bugs/deficiencies in the existing
mips.igen, and some spacing.

(3) The comments say:

    // In mips.igen, the semantics for many of the instructions were created
    // using code generated by gencode.  Those semantic segments could be
    // greatly simplified.

    that's all of the unnecessary do_* functions, right?  Eliminate
    the unnecessary ones of those (i.e., the ones where it's just an
    extra fn call).

(4) Add in some additional features to existing code (e.g. input
checking macros).

(5) convert to new branch delay slot handling.

(6) add mipsV ISA instructions.

(7) add mips32/mips64 ISA instructions.


I think that'll be a good ordering/breakdown.


chris