This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] [PATCH] handle timeout in read_frame
- To: Michael Elizabeth Chastain <chastain at cygnus dot com>
- Subject: Re: [RFA] [PATCH] handle timeout in read_frame
- From: Andrew Cagney <ac131313 at cygnus dot com>
- Date: Thu, 24 Aug 2000 19:04:18 +1000
- CC: gdb-patches at sourceware dot cygnus dot com
- References: <200008212018.NAA01965@train2.cygnus.com>
Michael Elizabeth Chastain wrote:
>
> This patch fixes a timeout bug in remote.c.
>
> If a timeout occurs while reading the packet checksum, read_frame
> treats the timeout as an ordinary input character with a value of "-2".
> gdb not only loses that frame: it throws an error out of fromhex.
> This causes a lot of random testsuite failures with the message "Reply
> contains invalid hex digit -2".
>
> Testing: first, find a host, target, and testsuite that suffer from the
> "invalid hex digit -2" problem. I used a Red Hat Linux 6.0 box for the
> host, i386-pc-aout for the target and call-ar-st.exp for the testsuite.
> Here's an excerpt from gdb.log before the patch:
>
> Reply contains invalid hex digit -2
> FAIL: gdb.base/call-ar-st.exp: (timeout) print print_array_rep(*list1, *list2, *list3)
>
> After the patch, these errors go away.
The patch is fine (one less unchecked readchar()!!!). What was the
ChangeLog entry?
Andrew