Re: gdb 5.0: solib.c (LM_ADDR) should be signed, not unsigned

[Andrew Cagney <ac131313 at cygnus dot com>]

Michael Snyder wrote:

> > > -#define LM_ADDR(so) (SOLIB_EXTRACT_ADDRESS ((so) -> lm.l_addr))
> > > +#define LM_ADDR(so) (SOLIB_EXTRACT_SIGNED_ADDRESS ((so) -> lm.l_addr))
> > >  #define LM_NEXT(so) (SOLIB_EXTRACT_ADDRESS ((so) -> lm.l_next))
> > >  #define LM_NAME(so) (SOLIB_EXTRACT_ADDRESS ((so) -> lm.l_name))
> > >  /* Test for first link map entry; first entry is the exec-file. */
> >
> > I don't think this is right.  I think it would sign extend that address
> > for all targets - wrong in 99% of cases.
> 
> By the way, I will shortly be submitting changes that
> make all these macros into functions.  Should I do it
> sooner rather than later?  Will that help at all?

Yes please.
It won't help Maciej's problem though.  It looks to be a real bug - I
can't confirm or deny it (JimB?) as I don't have an ELF spec lying
around.

	Andrew