This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: find_saved_register(frame) -> next/prev frame?



> It seems that find_saved_register is called only by mips_get_saved_register()
> and default_get_saved_register().
> 
> There is another function, generic_get_saved_register() in
> blockframe.c which is basically identical to
> default_get_saved_register and which doesn't call
> find_saved_register(). Maybe the author realized that
> find_saved_register() was wrong, but didn't want to touch the exisitng
> code.

This is probably true (Hi mike :-).  However, only a few targets are
using that new version.  Most targets appear to still use
default_get_saved_register().  Surely someone will have noticed that
up/down didn't work right?

> Probably we should switch the macro GET_SAVED_REGISTER to be
> generic_get_saved_register instead of default_get_saved_register and
> see what happens.

If we can demonstrate that it is wrong then yes.

> Elena

	Andrew

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]